lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/4] iio: accel: adxl372: add additional events ABIs
From
Date
On 3/18/20 12:09 PM, Alexandru Tachici wrote:
> Adxl372 uses the standard event interface. The additional
> ABIs aim to explain to the user that the values set in
> ./events/thresh_falling_period and ./events/thresh_rising_period
> control the state of the device, not just the events timings.
>

Hi,

I'm not convinced this is a good idea. Since this is non-standard ABI
the user would likely have to consult the documentation to figure out
what this means. So we might as well document in the documentation that
for peak mode the thresholds are configured through the event API.

- Lars

\
 
 \ /
  Last update: 2020-03-18 11:17    [W:0.054 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site