Messages in this thread | | | Subject | Re: [PATCH v3 3/4] iio: accel: adxl372: add additional events ABIs | From | Lars-Peter Clausen <> | Date | Wed, 18 Mar 2020 11:15:52 +0100 |
| |
On 3/18/20 12:09 PM, Alexandru Tachici wrote: > Adxl372 uses the standard event interface. The additional > ABIs aim to explain to the user that the values set in > ./events/thresh_falling_period and ./events/thresh_rising_period > control the state of the device, not just the events timings. >
Hi,
I'm not convinced this is a good idea. Since this is non-standard ABI the user would likely have to consult the documentation to figure out what this means. So we might as well document in the documentation that for peak mode the thresholds are configured through the event API.
- Lars
| |