lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/15] powerpc/watchpoint: Convert thread_struct->hw_brk to an array
From
Date


Le 18/03/2020 à 09:36, Ravi Bangoria a écrit :
>
>
> On 3/17/20 4:07 PM, Christophe Leroy wrote:
>>
>>
>> Le 09/03/2020 à 09:58, Ravi Bangoria a écrit :
>>> So far powerpc hw supported only one watchpoint. But Future Power
>>> architecture is introducing 2nd DAWR. Convert thread_struct->hw_brk
>>> into an array.
>>
>> Looks like you are doing a lot more than that in this patch.
>>
>> Should this patch be splitted in two parts ?
>
> So far thread_struct->hw_brk was a normal variable so accessing it was
> simple.
> Once it gets converted into an array, loop needs to be used to access
> it. So
> all misc changes are basically converting simple access into loops.
>
> I don't see how this can be splitted.
>

You could first change all thread_struct->hw_brk to
thread_struct->hw_brk[0] or thread_struct->hw_brk[i] when you know that
i can only be 0 for now. Then add the loops and new functions in a
second patch.

Christophe

\
 
 \ /
  Last update: 2020-03-18 09:57    [W:0.095 / U:12.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site