Messages in this thread | | | Date | Tue, 17 Mar 2020 10:08:58 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH] arm64/kernel: Simplify __cpu_up() by bailing out early |
| |
On Tue, Mar 17, 2020 at 10:06:09AM +0000, Mark Rutland wrote: > On Mon, Mar 02, 2020 at 12:21:35PM +0000, Mark Rutland wrote: > > On Mon, Mar 02, 2020 at 01:03:40PM +1100, Gavin Shan wrote: > > > The function __cpu_up() is invoked to bring up the target CPU through > > > the backend, PSCI for example. The nested if statements won't be needed > > > if we bail out early on the following two conditions where the status > > > won't be checked. The code looks simplified in that case. > > > > > > * Error returned from the backend (e.g. PSCI) > > > * The target CPU has been marked as onlined > > > > > > Signed-off-by: Gavin Shan <gshan@redhat.com> > > > > FWIW, this looks like a nice cleanup to me: > > > > Reviewed-by: Mark Rutland <mark.rutland@arm.com> > > Catalin, are you happy to pick this up?
Yes, it was on my list to pick up already, just haven't got around to it yet.
-- Catalin
| |