Messages in this thread | | | From | Brendan Higgins <> | Date | Tue, 17 Mar 2020 12:00:03 -0700 | Subject | Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc |
| |
On Tue, Mar 17, 2020 at 10:38 AM Alan Maguire <alan.maguire@oracle.com> wrote: > > When building UML with glibc 2.17 installed, compilation > of arch/um/os-Linux/file.c fails due to failure to find > FALLOC_FL_PUNCH_HOLE and FALLOC_FL_KEEP_SIZE definitions. > > It appears that /usr/include/bits/fcntl-linux.h (indirectly > included by /usr/include/fcntl.h) does not include falloc.h > with an older glibc, whereas a more up-to-date version > does. > > Adding the direct include to file.c resolves the issue > and does not cause problems for more recent glibc. > > Fixes: 50109b5a03b4 ("um: Add support for DISCARD in the UBD Driver") > Cc: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
| |