Messages in this thread | | | Subject | Re: [PATCH 01/10] KVM: nVMX: Move reflection check into nested_vmx_reflect_vmexit() | From | Paolo Bonzini <> | Date | Tue, 17 Mar 2020 18:38:20 +0100 |
| |
On 17/03/20 18:00, Vitaly Kuznetsov wrote: > > On the other hand, I'm a great fan of splitting checkers ('pure' > functions) from actors (functions with 'side-effects') and > nested_vmx_exit_reflected() while looking like a checker does a lot of > 'acting': nested_mark_vmcs12_pages_dirty(), trace printk.
Good idea (trace_printk is not a big deal, but nested_mark_vmcs12_pages_dirty should be done outside). I'll send a patch, just to show that I can still write KVM code. :)
Paolo
| |