lkml.org 
[lkml]   [2020]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v4 10/27] ata: remove EXPORT_SYMBOL_GPL()s not used by modules
Date
Remove EXPORT_SYMBOL_GPL()s for functions used only by
the core libata code.

Code size savings on m68k arch using (modified) atari_defconfig:

text data bss dec hex filename
before:
39838 573 40 40451 9e03 drivers/ata/libata-core.o
21071 105 576 21752 54f8 drivers/ata/libata-scsi.o
17519 18 0 17537 4481 drivers/ata/libata-eh.o
after:
39688 573 40 40301 9d6d drivers/ata/libata-core.o
21040 105 576 21721 54d9 drivers/ata/libata-scsi.o
17405 18 0 17423 440f drivers/ata/libata-eh.o

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/ata/libata-core.c | 5 -----
drivers/ata/libata-eh.c | 4 ----
drivers/ata/libata-scsi.c | 1 -
3 files changed, 10 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index dae625fc5e8a..e4df091fdcde 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -80,7 +80,6 @@ const struct ata_port_operations ata_base_port_ops = {
.sched_eh = ata_std_sched_eh,
.end_eh = ata_std_end_eh,
};
-EXPORT_SYMBOL_GPL(ata_base_port_ops);

const struct ata_port_operations sata_port_ops = {
.inherits = &ata_base_port_ops,
@@ -899,7 +898,6 @@ void ata_unpack_xfermask(unsigned long xfer_mask, unsigned long *pio_mask,
if (udma_mask)
*udma_mask = (xfer_mask & ATA_MASK_UDMA) >> ATA_SHIFT_UDMA;
}
-EXPORT_SYMBOL_GPL(ata_unpack_xfermask);

static const struct ata_xfer_ent {
int shift, bits;
@@ -3437,7 +3435,6 @@ u8 ata_timing_cycle2mode(unsigned int xfer_shift, int cycle)

return last_mode;
}
-EXPORT_SYMBOL_GPL(ata_timing_cycle2mode);

/**
* ata_down_xfermask_limit - adjust dev xfer masks downward
@@ -5058,7 +5055,6 @@ void ata_sg_init(struct ata_queued_cmd *qc, struct scatterlist *sg,
qc->n_elem = n_elem;
qc->cursg = qc->sg;
}
-EXPORT_SYMBOL_GPL(ata_sg_init);

#ifdef CONFIG_HAS_DMA

@@ -6158,7 +6154,6 @@ void ata_host_get(struct ata_host *host)
{
kref_get(&host->kref);
}
-EXPORT_SYMBOL_GPL(ata_host_get);

void ata_host_put(struct ata_host *host)
{
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 827d437d8cb4..3b8d276b5107 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1212,7 +1212,6 @@ void ata_eh_thaw_port(struct ata_port *ap)

trace_ata_port_thaw(ap);
}
-EXPORT_SYMBOL_GPL(ata_eh_thaw_port);

static void ata_eh_scsidone(struct scsi_cmnd *scmd)
{
@@ -1247,7 +1246,6 @@ void ata_eh_qc_complete(struct ata_queued_cmd *qc)
scmd->retries = scmd->allowed;
__ata_eh_qc_complete(qc);
}
-EXPORT_SYMBOL_GPL(ata_eh_qc_complete);

/**
* ata_eh_qc_retry - Tell midlayer to retry an ATA command after EH
@@ -1267,7 +1265,6 @@ void ata_eh_qc_retry(struct ata_queued_cmd *qc)
scmd->allowed++;
__ata_eh_qc_complete(qc);
}
-EXPORT_SYMBOL_GPL(ata_eh_qc_retry);

/**
* ata_dev_disable - disable ATA device
@@ -4044,7 +4041,6 @@ void ata_do_eh(struct ata_port *ap, ata_prereset_fn_t prereset,

ata_eh_finish(ap);
}
-EXPORT_SYMBOL_GPL(ata_do_eh);

/**
* ata_std_error_handler - standard error handler
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 2b0262aa3bcc..2bf1376bc027 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4522,7 +4522,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd)

cmd->scsi_done(cmd);
}
-EXPORT_SYMBOL_GPL(ata_scsi_simulate);

int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht)
{
--
2.24.1
\
 
 \ /
  Last update: 2020-03-17 15:45    [W:0.197 / U:6.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site