lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 3/7] scsi: ufs: introduce common delay function
From
Date
On 3/16/20 1:52 AM, Stanley Chu wrote:
> +void ufshcd_wait_us(unsigned long us, unsigned long tolerance, bool can_sleep)
> +{
> + if (!us)
> + return;
> +
> + if (us < 10 || !can_sleep)
> + udelay(us);
> + else
> + usleep_range(us, us + tolerance);
> +}
> +EXPORT_SYMBOL_GPL(ufshcd_wait_us);

I don't like this function because I think it makes the UFS code harder
to read instead of easier. The 'can_sleep' argument is only set by one
caller which I think is a strong argument to remove that argument again
and to move the code that depends on that argument from the above
function into the caller. Additionally, it is not possible to comprehend
what a ufshcd_wait_us() call does without looking up the function
definition to see what the meaning of the third argument is.

Please drop this patch.

Thanks,

Bart.

\
 
 \ /
  Last update: 2020-03-16 17:23    [W:0.101 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site