lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] KVM: X86: correct meaningless kvm_apicv_activated() check
Date
Sean Christopherson <sean.j.christopherson@intel.com> writes:

> On Mon, Mar 16, 2020 at 09:33:50AM +0100, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>> > + if ((old == 0) == (new == 0))
>> > + return;
>>
>> This is a very laconic expression I personally find hard to read :-)
>>
>> /* Check if WE actually changed APICv state */
>> if ((!old && !new) || (old && new))
>> return;
>>
>> would be my preference (not strong though, I read yours several times
>> and now I feel like I understand it just fine :-)
>
> Or maybe this to avoid so many equals signs?
>
> if (!old == !new)
> return;
>

if (!!old == !!new)
return;

to make it clear we're converting them to 1/0 :-)

--
Vitaly

\
 
 \ /
  Last update: 2020-03-16 16:52    [W:0.084 / U:1.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site