lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
Date
Hi Borislav,

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: 2020年3月16日 18:44
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: mchehab@kernel.org; tony.luck@intel.com; james.morse@arm.com;
> rrichter@marvell.com; michal.simek@xilinx.com; manish.narani@xilinx.com;
> linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; Frank Li <frank.li@nxp.com>
> Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
> parameter
>
> On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> > Maybe you misunderstood the handle_error(), this function has already
> > distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> > And what I am doing in this patch is to remove the useless pinf->col
> > in ZynqMP part, which won't break the Zynq part.
>
> Ok, I see it now, thanks for clarifying.
>
> Now, in your v2 pls fix this check in handle_error():
>
> if (!priv->p_data->quirks) {
>
> to *actually* *explicitly* check that the platform for which this function is
> called, really supports interrupts, i.e., DDR_ECC_INTR_SUPPORT, and not that
> the ->quirks thing is != 0. Like the rest of the code does.
>

Ok, I will fix this check.

Best regards
Sherry Sun

> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&amp;data=02%7C01%7Csherry.sun%40nxp.com%7Ccd843239ffd
> d48a05ce408d7c996ebd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637199522356909838&amp;sdata=5p6JuXQQJgyjlaMOUH1cLLSDFbUzM
> R%2Fjzs5HC%2FeU1Zc%3D&amp;reserved=0
\
 
 \ /
  Last update: 2020-03-16 13:29    [W:0.050 / U:20.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site