Messages in this thread | | | Date | Mon, 16 Mar 2020 11:43:56 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter |
| |
On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote: > Maybe you misunderstood the handle_error(), this function has already > distinguished between Zynq and ZynqMP through priv->p_data->quirks. > And what I am doing in this patch is to remove the useless pinf->col in ZynqMP > part, which won't break the Zynq part.
Ok, I see it now, thanks for clarifying.
Now, in your v2 pls fix this check in handle_error():
if (!priv->p_data->quirks) {
to *actually* *explicitly* check that the platform for which this function is called, really supports interrupts, i.e., DDR_ECC_INTR_SUPPORT, and not that the ->quirks thing is != 0. Like the rest of the code does.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |