lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RESEND PATCH 1/3] mmc: host: Introduce the request_atomic() for the host
On Mon, Mar 16, 2020 at 7:48 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Wed, 4 Mar 2020 at 08:42, Baolin Wang <baolin.wang7@gmail.com> wrote:
> >
> > The SD host controller can process one request in the atomic context if
> > the card is nonremovable, which means we can submit next request in the
> > irq hard handler when using the MMC software queue to reduce the latency.
> > Thus this patch adds a new API request_atomic() for the host controller
> > and implement it for the SD host controller.
> >
> > Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> > ---
> > drivers/mmc/host/sdhci.c | 27 +++++++++++++++++++--------
> > drivers/mmc/host/sdhci.h | 1 +
> > include/linux/mmc/host.h | 3 +++
> > 3 files changed, 23 insertions(+), 8 deletions(-)
>
> I think the code split of the changes in the series can be improved a
> bit, so I suggest you move the code around in the series to reach
> this:
>
> 1. A patch that adds the new host ops callback, combined with the
> change you have in patch3.
> 2. The sdhci core specific changes, from $subject patch.
> 3. The sdhci-sprd changes, as in patch2.
>
> Other than that, I think the code looks good to me, besides a minor
> comment on patch2, see separate reply.

Sure. Will do as you suggested. Thanks.

--
Baolin Wang

\
 
 \ /
  Last update: 2020-03-17 03:01    [W:0.086 / U:6.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site