lkml.org 
[lkml]   [2020]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Makefile: disallow data races on gcc-10 as well
On Tue, 17 Mar 2020, Sergei Trofimovich wrote:

> gcc-10 will rename --param=allow-store-data-races=0
> to -fno-allow-store-data-races.
>
> The flag change happened at https://gcc.gnu.org/PR92046.
>
> CC: Jiri Kosina <jkosina@suse.cz>
> CC: Masahiro Yamada <masahiroy@kernel.org>
> CC: Michal Marek <michal.lkml@markovi.net>
> CC: linux-kbuild@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 171f2b004c8a..9696eb2cd5a1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -714,6 +714,7 @@ endif
>
> # Tell gcc to never replace conditional load with a non-conditional one
> KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0)
> +KBUILD_CFLAGS += $(call cc-option,-fno-allow-store-data-races)

I have to say I can't really read gcc sources without major cerebral pain,
so let me me dense here: what happens to gcc<10 if you pass
-fno-allow-store-data-races to it?

My expectation would be that it would just blow up in fatal error, meaning
that after we apply your patch, kernel couldn't be successfully compiled
by any compiler that doesn't understand '-fno-allow-store-data-races'
(which is just about any compiler on this planet).

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2020-03-17 01:59    [W:0.059 / U:5.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site