Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 16 Mar 2020 17:06:55 -0700 | Subject | Re: [PATCHv2 47/50] kdb: Don't play with console_loglevel |
| |
Hi,
On Mon, Mar 16, 2020 at 7:43 AM Dmitry Safonov <dima@arista.com> wrote: > > Print the stack trace with KERN_EMERG - it should be always visible. > > Playing with console_loglevel is a bad idea as there may be more > messages printed than wanted. Also the stack trace might be not printed > at all if printk() was deferred and console_loglevel was raised back > before the trace got flushed. > > Unfortunately, after rebasing on commit 2277b492582d ("kdb: Fix stack > crawling on 'running' CPUs that aren't the master"), kdb_show_stack() > uses now kdb_dump_stack_on_cpu(), which for now won't be converted as it > uses dump_stack() instead of show_stack(). > > Convert for now the branch that uses show_stack() and remove > console_loglevel exercise from that case. > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Jason Wessel <jason.wessel@windriver.com> > Cc: kgdb-bugreport@lists.sourceforge.net > Signed-off-by: Dmitry Safonov <dima@arista.com> > --- > kernel/debug/kdb/kdb_bt.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-)
Presuming that the rest of this series is deemed acceptable by those in charge, this patch looks fine to me:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
| |