Messages in this thread | | | From | Sergio Paracuellos <> | Date | Sun, 15 Mar 2020 15:17:54 +0100 | Subject | Re: [PATCH 0/2] gpio: mmio: introduce BGPIOF_NO_SET_ON_INPUT |
| |
Hi,
On Sun, Mar 15, 2020 at 1:14 PM Chuanhong Guo <gch981213@gmail.com> wrote: > > Currently gpio-hog doesn't work on gpio-mt7621 driver. On further > debugging, I noticed that set/clear register on this controller > only works on output pins. We need to setup pin direction before > writing values in bgpio_dir_out for a correct gpio-hog behavior. > This patchset introduces a new flag BGPIOF_NO_SET_ON_INPUT for > these kind of controller and set this flag for gpio-mt7621. > > Chuanhong Guo (2): > gpio: mmio: introduce BGPIOF_NO_SET_ON_INPUT > gpio: mt7621: add BGPIOF_NO_SET_ON_INPUT flag > > drivers/gpio/gpio-mmio.c | 23 +++++++++++++++++++---- > drivers/gpio/gpio-mt7621.c | 4 ++-- > include/linux/gpio/driver.h | 1 + > 3 files changed, 22 insertions(+), 6 deletions(-) >
This series looks good to me.
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Best regards, Sergio Paracuellos
> -- > 2.24.1 >
| |