lkml.org 
[lkml]   [2020]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: stmmac: platform: Fix misleading interrupt error msg
From
From: Markus Fuchs <mklntf@gmail.com>
Date: Thu, 12 Mar 2020 20:46:25 +0100

> On Wed, Mar 11, 2020 at 11:04:02PM -0700, David Miller wrote:
>> From: Markus Fuchs <mklntf@gmail.com>
>> Date: Fri, 6 Mar 2020 17:38:48 +0100
>>
>> > Not every stmmac based platform makes use of the eth_wake_irq or eth_lpi
>> > interrupts. Use the platform_get_irq_byname_optional variant for these
>> > interrupts, so no error message is displayed, if they can't be found.
>> > Rather print an information to hint something might be wrong to assist
>> > debugging on platforms which use these interrupts.
>> >
>> > Signed-off-by: Markus Fuchs <mklntf@gmail.com>
>>
>> What do you mean the error message is misleading right now?
>>
>> It isn't printing anything out at the moment in this situation.
>
> Commit 7723f4c5ecdb driver core: platform: Add an error message to
> platform_get_irq*()
>
> The above commit added a generic dev_err() output to the platform_get_irq_byname
> function.
>
> My patch uses the platform_get_irq_byname_optional function, which
> doesn't print anything and adds the original dev_err output as dev_info output
> to the driver.
> Otherwise there would be no output at all even for platforms in need of these
> irqs.

Aha, now I get it, thanks for explaining.

Applied, thank you.

\
 
 \ /
  Last update: 2020-03-15 05:01    [W:0.049 / U:4.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site