lkml.org 
[lkml]   [2020]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel
Hi Icenowy

A few comment below.

Sam

On Thu, Mar 12, 2020 at 12:33:26AM +0800, Icenowy Zheng wrote:
> Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel.
>
> Add its device tree binding.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> .../display/panel/xingbangda,xbd599.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml
> new file mode 100644
> index 000000000000..62816b34de31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/xingbangda,xbd599.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/xingbangda,xbd599.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xingbangda XBD599 5.99in MIPI-DSI LCD panel
> +
> +maintainers:
> + - Icenowy Zheng <icenowy@aosc.io>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: xingbangda,xbd599
> + reg: true
> + backlight: true
> + reset-gpios: true
> + vcc-supply:
> + description: regulator that supplies the VCC voltage
Fix indent - two chars, not three

> + iovcc-supply:
> + description: regulator that supplies the IOVCC voltage
Same here

> +
> +required:
> + - compatible
> + - reg
> + - backlight
> + - vcc-supply
> + - iovcc-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + &dsi {
Remove '&' - dt_binding_check will fail otherwise

> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "xingbangda,xbd599";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&reg_dldo2>;
> + vcc-supply = <&reg_ldo_io0>;
> + };
> + };
> +
> +...
> --
> 2.24.1

\
 
 \ /
  Last update: 2020-03-15 03:29    [W:0.065 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site