lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] i2c: mv64xxx: Implement I2C_M_RECV_LEN and I2C_FUNC_SMBUS_READ_BLOCK_DATA
From
Date
Hello all,



> Il giorno 13 mar 2020, alle ore 21:48, Gregory CLEMENT <gregory.clement@bootlin.com> ha scritto:
>
> Hello Wolfram,
>
>> On Sat, Jan 18, 2020 at 12:58:20PM +0100, Federico Fuga wrote:
>>> The i2c_mv64xxx driver doesn't implement the I2C_M_REC_LEN function
>>> essential to allow blocks with variable length to be read from an i2c
>>> slave.
>>> This is needed to implement the SMBus Read Block Data function.
>>>
>>> This patch implements the function by changing the bytes_left and
>>> msg len on the fly if the flag is specified.
>>>
>>> It has been successfully tested on Allwinner A33 with a special
>>> i2c chip that returns variable length blocks on reading.
>>>
>>> Signed-off-by: Federico Fuga <fuga@studiofuga.com>
>>> ---
>>
>> Gregory, any comment? I can't say much about the implementation. In
>> general, this is a nice feature to have...
>
> I thought I was already sent a reviewed by, as I reviewed this patch
> before Frederico actually sent it.
>
> So you can even add a
>
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>
> Thanks,


For what it worth, I can confirm that after many weeks of use the patch works as expected without any issue.


Federico





\
 
 \ /
  Last update: 2020-03-13 22:06    [W:0.373 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site