lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;
Hello Joe,

On Tue, 10 Mar 2020 21:51:22 -0700
Joe Perches <joe@perches.com> wrote:

> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

I think the patch is OK, but the automatically-generated first
commit message line has a room for improvement.

But, as I understood, it has chances to be re-sent as one patch for
all files.

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/mach-ep93xx/crunch.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/crunch.c b/arch/arm/mach-ep93xx/crunch.c
> index 1c05c5b..f02e978 100644
> --- a/arch/arm/mach-ep93xx/crunch.c
> +++ b/arch/arm/mach-ep93xx/crunch.c
> @@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
> * FALLTHROUGH: Ensure we don't try to overwrite our newly
> * initialised state information on the first fault.
> */
> - /* Fall through */
> -
> + fallthrough;
> case THREAD_NOTIFY_EXIT:
> crunch_task_release(thread);
> break;

--
Alexander Sverdlin.

\
 
 \ /
  Last update: 2020-03-13 20:28    [W:0.196 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site