Messages in this thread | | | Subject | Re: [PATCH v3 00/26] Introduce common headers for vDSO | From | Dmitry Safonov <> | Date | Fri, 13 Mar 2020 16:19:23 +0000 |
| |
Hi Vincenzo, all
I like the idea, but I'm wondering if we could have less-grained headers? Like, AFAICS the patches create headers < 10 lines and even mostly < 5 lines.. I like that header's names perfectly describe what's inside, but I'm not sure how effective to have a lot of extra-small includes.
Or maybe there's a plan to grow the code in them?
On 3/13/20 3:43 PM, Vincenzo Frascino wrote: [..] > create mode 100644 arch/arm/include/asm/vdso/clocksource.h > create mode 100644 arch/arm/include/asm/vdso/cp15.h > create mode 100644 arch/arm/include/asm/vdso/processor.h > create mode 100644 arch/arm64/include/asm/vdso/arch_timer.h > create mode 100644 arch/arm64/include/asm/vdso/clocksource.h > create mode 100644 arch/arm64/include/asm/vdso/processor.h > create mode 100644 arch/mips/include/asm/vdso/clocksource.h > create mode 100644 arch/mips/include/asm/vdso/processor.h > create mode 100644 arch/x86/include/asm/vdso/clocksource.h > create mode 100644 arch/x86/include/asm/vdso/processor.h > create mode 100644 include/vdso/bits.h > create mode 100644 include/vdso/clocksource.h > create mode 100644 include/vdso/const.h > create mode 100644 include/vdso/jiffies.h > create mode 100644 include/vdso/ktime.h > create mode 100644 include/vdso/limits.h > create mode 100644 include/vdso/math64.h > create mode 100644 include/vdso/processor.h > create mode 100644 include/vdso/time.h > create mode 100644 include/vdso/time32.h > create mode 100644 include/vdso/time64.h
Maybe we could made them less-grained?
I.e, time32 + time64 + time.h => time.h?
Thanks for Cc, Dmitry
| |