Messages in this thread | | | Subject | Re: [PATCH] dma-buf: heaps: bugfix for selftest failure | From | shuah <> | Date | Fri, 13 Mar 2020 10:10:21 -0600 |
| |
On 3/3/20 10:34 PM, Leon He wrote: > If the 'name' array in check_vgem() was not initialized to null, the > value of name[4] may be random. Which will cause strcmp(name, "vgem") > failed.
Nit: "to fail" instead of "failed"
> > Signed-off-by: Leon He <leon.he@unisoc.com> > --- > tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > index cd5e1f6..21f3d19 100644 > --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > @@ -22,7 +22,7 @@ > static int check_vgem(int fd) > { > drm_version_t version = { 0 }; > - char name[5]; > + char name[5] = { 0 }; > int ret; > > version.name_len = 4; >
return !strcmp(name, "vgem");
While you are at it, why not change strcmp() to strncmp()?
thanks, -- Shuah
| |