lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 10/11] reset: imx: Add audiomix reset controller support
From
Date
On Fri, 2020-03-13 at 16:16 +0200, Abel Vesa wrote:
[...]
> > > + if (assert) {
> > > + pm_runtime_get_sync(rcdev->dev);
> >
> > This seems wrong. Why is the runtime PM reference count incremented when
> > a reset is asserted ...
>
> The audiomix IP has its own power domain.

The reset controller does not control the power domain for its
consumers. The consumer of this reset should implement runtime PM.

> The way I see it, when the last deassert is done, there is no point
> in keeping the audiomix on. So, unless the clock controller part of it does it,
> the audiomix will be powered down.

You mean when the last assert is done? Presumably the driver wants to
use the hardware after deasserting the reset and asserts the reset when
it is done.

regards
Philipp

\
 
 \ /
  Last update: 2020-03-13 16:56    [W:0.111 / U:30.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site