lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] platform/chrome: notify: Add driver data struct
Date
Hi Prashant,

On 12/3/20 11:08, Prashant Malani wrote:
> Introduce a device driver data structure, cros_usbpd_notify_data, in
> which we can store the notifier block object and pointers to the struct
> cros_ec_device and struct device objects.
>
> This will make it more convenient to access these pointers when
> executing both platform and ACPI callbacks.
>
> While we are here, also add a dev_info print declaring successful device
> registration at the end of the platform probe function.
>

This info can be obtained by other means, i.e function tracing or
initcall_debug. There is no need to repeat the same explicitly in the driver.

> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/platform/chrome/cros_usbpd_notify.c | 30 ++++++++++++++-------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..edcb346024b07 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -16,6 +16,12 @@
>
> static BLOCKING_NOTIFIER_HEAD(cros_usbpd_notifier_list);
>
> +struct cros_usbpd_notify_data {
> + struct device *dev;
> + struct cros_ec_device *ec;
> + struct notifier_block nb;
> +};
> +
> /**
> * cros_usbpd_register_notify - Register a notifier callback for PD events.
> * @nb: Notifier block pointer to register
> @@ -98,23 +104,28 @@ static int cros_usbpd_notify_probe_plat(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent);
> - struct notifier_block *nb;
> + struct cros_usbpd_notify_data *pdnotify;
> int ret;
>
> - nb = devm_kzalloc(dev, sizeof(*nb), GFP_KERNEL);
> - if (!nb)
> + pdnotify = devm_kzalloc(dev, sizeof(*pdnotify), GFP_KERNEL);
> + if (!pdnotify)
> return -ENOMEM;
>
> - nb->notifier_call = cros_usbpd_notify_plat;
> - dev_set_drvdata(dev, nb);
> + pdnotify->dev = dev;
> + pdnotify->ec = ecdev->ec_dev;
> + pdnotify->nb.notifier_call = cros_usbpd_notify_plat;
> +
> + dev_set_drvdata(dev, pdnotify);
>
> ret = blocking_notifier_chain_register(&ecdev->ec_dev->event_notifier,
> - nb);
> + &pdnotify->nb);
> if (ret < 0) {
> dev_err(dev, "Failed to register notifier\n");
> return ret;
> }
>
> + dev_info(dev, "Chrome EC PD notify device registered.\n");
> +

This is only noise to the kernel log, remove it.

> return 0;
> }
>
> @@ -122,10 +133,11 @@ static int cros_usbpd_notify_remove_plat(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct cros_ec_dev *ecdev = dev_get_drvdata(dev->parent);
> - struct notifier_block *nb =
> - (struct notifier_block *)dev_get_drvdata(dev);
> + struct cros_usbpd_notify_data *pdnotify =
> + (struct cros_usbpd_notify_data *)dev_get_drvdata(dev);
>
> - blocking_notifier_chain_unregister(&ecdev->ec_dev->event_notifier, nb);
> + blocking_notifier_chain_unregister(&ecdev->ec_dev->event_notifier,
> + &pdnotify->nb);
>
> return 0;
> }
>

\
 
 \ /
  Last update: 2020-03-13 13:41    [W:0.460 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site