lkml.org 
[lkml]   [2020]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fs: Fix missing 'bit' in comment
From
Date
Hi,

On 3/13/20 2:46 AM, Chucheng Luo wrote:
> The missing word may make it hard for other developers to
> understand it.
>
> Signed-off-by: Chucheng Luo <luochucheng@vivo.com>

This new version also looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

p.s.

In the future please mark new versions as such by using e.g.:

git send-email --subject-prefix="PATCH v2" ...

Actually, it would be good to resend this patch (with my
Acked-by added to the commit msg) this way because now there
is no way for the fs maintainers to figure out which one
of the 2 patches you've send out to apply.



> ---
> fs/vboxsf/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
> index dd147b490982..4d569f14a8d8 100644
> --- a/fs/vboxsf/dir.c
> +++ b/fs/vboxsf/dir.c
> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
> d_type = vboxsf_get_d_type(info->info.attr.mode);
>
> /*
> - * On 32 bit systems pos is 64 signed, while ino is 32 bit
> + * On 32-bit systems pos is 64-bit signed, while ino is 32-bit
> * unsigned so fake_ino may overflow, check for this.
> */
> if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>

\
 
 \ /
  Last update: 2020-03-13 11:46    [W:0.036 / U:5.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site