Messages in this thread | | | Subject | Re: [PATCH v13 2/5] soc: qcom: rpmh: Update dirty flag only when data changes | From | Maulik Shah <> | Date | Fri, 13 Mar 2020 14:23:54 +0530 |
| |
Hi,
On 3/10/2020 5:12 AM, Doug Anderson wrote: > Hi, > > On Mon, Mar 9, 2020 at 2:31 AM Maulik Shah <mkshah@codeaurora.org> wrote: >> Currently rpmh ctrlr dirty flag is set for all cases regardless of data >> is really changed or not. Add changes to update dirty flag when data is >> changed to newer values. Update dirty flag everytime when data in batch >> cache is updated since rpmh_flush() may get invoked from any CPU instead >> of only last CPU going to low power mode. >> >> Also move dirty flag updates to happen from within cache_lock and remove >> unnecessary INIT_LIST_HEAD() call and a default case from switch. >> >> Fixes: 600513dfeef3 ("drivers: qcom: rpmh: cache sleep/wake state requests") >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> Reviewed-by: Srinivas Rao L <lsrao@codeaurora.org> >> Reviewed-by: Evan Green <evgreen@chromium.org> >> --- >> drivers/soc/qcom/rpmh.c | 19 +++++++++++-------- >> 1 file changed, 11 insertions(+), 8 deletions(-) > Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks for the review doug.
Hi bjorn,
can you please pull in first 2 changes in the series.
while the others are still under discussion, pulling in these first 2 will help avoid send them each time.
Thanks,
Maulik
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |