lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;
From
Date
On Thu, 2020-03-12 at 12:45 -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote:
> > On Wed, 2020-03-11 at 23:23 -0700, David Miller wrote:
> > > Joe, please use Subject line subsystem prefixes consistent with what would
> > > be used for other changes to these drivers.
> >
> > Not easy to do for scripted patches.
> > There's no mechanism that scriptable.
>
> I have this to show me the top 3 prefixes used for files currently
> modified in my tree:
>
> tgs() {
> local fs
>
> fs=$(git status -s | sed -n 's/ M //p')
>
> git log --oneline --no-merges -- $fs | \
> sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \
> sort | uniq -c | sort -rn | head -3
> }
>
> You could probably massage it to just give you to top one and feed
> that into git commit template?

I had already tried that via:

$ cat get_patch_subject_prefix.bash
#!/bin/bash
git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \
cut -f1 -d":" | \
sort | uniq -c | sort -rn | head -1 | \
sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//'
$

It doesn't work very well for many of the subsystems.

For instance, this script produces things like:

ARM/ZYNQ ARCHITECTURE: treewide
FCOE SUBSYSTEM (libfc, libfcoe, fcoe): scsi
WOLFSON MICROELECTRONICS DRIVERS: ASoC

There isn't a great single mechanism for this.

At various times, I have proposed adding a grammar for
patch subject titles to MAINTAINERS.

Like:
https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/


\
 
 \ /
  Last update: 2020-03-12 20:54    [W:0.104 / U:4.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site