lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sfc: ethtool: Refactor to remove fallthrough comments in case blocks
From
From: Joe Perches <joe@perches.com>
Date: Tue, 10 Mar 2020 19:41:41 -0700

> Converting fallthrough comments to fallthrough; creates warnings
> in this code when compiled with gcc.
>
> This code is overly complicated and reads rather better with a
> little refactoring and no fallthrough uses at all.
>
> Remove the fallthrough comments and simplify the written source
> code while reducing the object code size.
>
> Consolidate duplicated switch/case blocks for IPV4 and IPV6.
>
> defconfig x86-64 with sfc:
>
> $ size drivers/net/ethernet/sfc/ethtool.o*
> text data bss dec hex filename
> 10055 12 0 10067 2753 drivers/net/ethernet/sfc/ethtool.o.new
> 10135 12 0 10147 27a3 drivers/net/ethernet/sfc/ethtool.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>

Applied to net-next.

\
 
 \ /
  Last update: 2020-03-12 19:31    [W:0.065 / U:33.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site