Messages in this thread | | | Subject | Re: [PATCH v2 1/8] scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc() | From | "Asutosh Das (asd)" <> | Date | Thu, 12 Mar 2020 10:27:27 -0700 |
| |
On 3/12/2020 4:09 AM, Stanley Chu wrote: > In ufshcd_disable_tx_lcc(), if ufshcd_dme_get() or ufshcd_dme_peer_get() > get fail, uninitialized variable "tx_lanes" may be used as unexpected lane > ID for DME configuration. > > Fix this issue by initializing "tx_lanes". > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 5698f1164a5e..314e808b0d4e 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4315,7 +4315,7 @@ EXPORT_SYMBOL_GPL(ufshcd_hba_enable); > > static int ufshcd_disable_tx_lcc(struct ufs_hba *hba, bool peer) > { > - int tx_lanes, i, err = 0; > + int tx_lanes = 0, i, err = 0; > > if (!peer) > ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), >
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project
| |