Messages in this thread | | | Date | Wed, 11 Mar 2020 23:07:58 -0700 (PDT) | Subject | Re: [PATCH] Fix off by one in samsung driver strncpy size arg | From | David Miller <> |
| |
From: Dominik 'disconnect3d' Czarnota <dominik.b.czarnota@gmail.com> Date: Mon, 9 Mar 2020 16:22:50 +0100
> From: disconnect3d <dominik.b.czarnota@gmail.com> > > This patch fixes an off-by-one error in strncpy size argument in > drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c. The issue is that in: > > strncmp(opt, "eee_timer:", 6) > > the passed string literal: "eee_timer:" has 10 bytes (without the NULL > byte) and the passed size argument is 6. As a result, the logic will > also accept other, malformed strings, e.g. "eee_tiXXX:". > > This bug doesn't seem to have any security impact since its present in > module's cmdline parsing code. > > Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
Applied, thank you.
| |