lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Fix off by one in samsung driver strncpy size arg
From
From: Dominik 'disconnect3d' Czarnota <dominik.b.czarnota@gmail.com>
Date: Mon, 9 Mar 2020 16:22:50 +0100

> From: disconnect3d <dominik.b.czarnota@gmail.com>
>
> This patch fixes an off-by-one error in strncpy size argument in
> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c. The issue is that in:
>
> strncmp(opt, "eee_timer:", 6)
>
> the passed string literal: "eee_timer:" has 10 bytes (without the NULL
> byte) and the passed size argument is 6. As a result, the logic will
> also accept other, malformed strings, e.g. "eee_tiXXX:".
>
> This bug doesn't seem to have any security impact since its present in
> module's cmdline parsing code.
>
> Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>

Applied, thank you.

\
 
 \ /
  Last update: 2020-03-12 07:08    [W:0.033 / U:12.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site