lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 00/27] ata: optimize core code size on PATA only setups
From
Date
On 2/27/20 11:21 AM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> There have been reports in the past of libata core code size
> being a problem in migration from deprecated IDE subsystem on
> legacy PATA only systems, i.e.:
>
> https://lore.kernel.org/linux-ide/db2838b7-4862-785b-3a1d-3bf09811340a@gmail.com/
>
> This patchset re-organizes libata core code to exclude SATA
> specific code from being built for PATA only setups.
>
> The end result is up to 24% (by 23949 bytes, from 101769 bytes to
> 77820 bytes) smaller libata core code size (as measured for m68k
> arch using modified atari_defconfig) on affected setups.
>
> I've tested this patchset using pata_falcon driver under ARAnyM
> emulator.
>
>
> patches #1-11 are general fixes/cleanups done in the process of
> making the patchset (there should be no inter-dependencies between
> them except patch #10 which depends on patch #9)
>
> patch #12 separates PATA timings code to libata-pata-timings.c file
>
> patches #13-15 let compiler optimize out SATA specific code on
> non-SATA hosts by adding !IS_ENABLED(CONFIG_SATA_HOST) instances
>
> patches #16-22 separate SATA only code from libata-core.c file to
> libata-sata.c one
>
> patches #23-24 separate SATA only code from libata-scsi.c file to
> libata-sata.c one
>
> patches #25-26 separate SATA only code from libata-eh.c file to
> libata-sata.c one
>
> patch #27 makes "libata.force" kernel parameter optional

Bart, patch #2 seemed to have an issue, are you going to resend
this patchset?

--
Jens Axboe

\
 
 \ /
  Last update: 2020-03-12 15:09    [W:0.119 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site