lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 05/15] ethtool: set netdev features with FEATURES_SET request
On Wed, Mar 11, 2020 at 03:56:32PM -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2020 22:40:28 +0100 (CET) Michal Kubecek wrote:
> > + if (!(req_info.flags & ETHTOOL_FLAG_OMIT_REPLY)) {
> > + bool compact = req_info.flags & ETHTOOL_FLAG_COMPACT_BITSETS;
>
> is req_info->flags validated anywhere to make sure users get an error
> when they set a bit unrecognized by the kernel? :S

It's not and it it definitely should be. As this also affects code which
is already in mainline, I'll send a patch with the check for net tree.

Michal

\
 
 \ /
  Last update: 2020-03-12 10:46    [W:0.045 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site