lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectR: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
Date
> On Wed 11 Mar 06:09 PDT 2020, Ansuel Smith wrote:
>
> > ipq806x rpm definition was missing for a long time.
> > Add this to make this soc support rpm.
> >
>
> I merged the dt-binding patch, but please update dts to use:
> compatible = "qcom,scm-ipq806x", "qcom,scm";
>
> instead of adding the platform specific compatible in the driver.
>
> Regards,
> Bjorn
>

Should I drop the added compatible in qcom_scm.c or just
keep it and add the definition in the ipq806x dts?

> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > drivers/firmware/qcom_scm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qcom_scm.c
> b/drivers/firmware/qcom_scm.c
> > index 059bb0fbae9e..d13ef3cd8cf5 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -1144,6 +1144,7 @@ static const struct of_device_id
> qcom_scm_dt_match[] = {
> >
> SCM_HAS_BUS_CLK)
> > },
> > { .compatible = "qcom,scm-ipq4019" },
> > + { .compatible = "qcom,scm-ipq806x" },
> > { .compatible = "qcom,scm-msm8660", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8960", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8916", .data = (void
> *)(SCM_HAS_CORE_CLK |
> > --
> > 2.25.0
> >

\
 
 \ /
  Last update: 2020-03-12 10:26    [W:0.047 / U:7.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site