Messages in this thread | | | Date | Fri, 13 Mar 2020 00:58:31 +0000 | From | Luis Chamberlain <> | Subject | Re: [PATCH v2 2/4] fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once() |
| |
On Thu, Mar 12, 2020 at 01:25:50PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > After request_module(), nothing is stopping the module from being > unloaded until someone takes a reference to it via try_get_module(). > > The WARN_ONCE() in get_fs_type() is thus user-reachable, via userspace > running 'rmmod' concurrently. > > Since WARN_ONCE() is for kernel bugs only, not for user-reachable > situations, downgrade this warning to pr_warn_once(). > > Cc: stable@vger.kernel.org > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jeff Vander Stoep <jeffv@google.com> > Cc: Jessica Yu <jeyu@kernel.org> > Cc: Kees Cook <keescook@chromium.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: NeilBrown <neilb@suse.com> > Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
| |