lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/15] AMD ntb driver fixes and improvements
On Fri, Feb 07, 2020 at 04:28:53PM +0530, Sanjay R Mehta wrote:
>
>
> On 2/5/2020 9:24 PM, Arindam Nath wrote:
> > [CAUTION: External Email]
> >
> > This patch series fixes some bugs in the existing
> > AMD NTB driver, cleans-up code, and modifies the
> > code to handle NTB link-up/down events. The series
> > is based on Linus' tree,
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >
> > Arindam Nath (15):
> > NTB: Fix access to link status and control register
> > NTB: clear interrupt status register
> > NTB: Enable link up and down event notification
> > NTB: define a new function to get link status
> > NTB: return the side info status from amd_poll_link
> > NTB: set peer_sta within event handler itself
> > NTB: remove handling of peer_sta from amd_link_is_up
> > NTB: handle link down event correctly
> > NTB: handle link up, D0 and D3 events correctly
> > NTB: move ntb_ctrl handling to init and deinit
> > NTB: add helper functions to set and clear sideinfo
> > NTB: return link up status correctly for PRI and SEC
> > NTB: remove redundant setting of DB valid mask
> > NTB: send DB event when driver is loaded or un-loaded
> > NTB: add pci shutdown handler for AMD NTB
>
> The patch series looks good to me. Thanks for the changes.
>
> For all the ntb_hw_amd changes:
>
> Reviewed-by: Sanjay R Mehta <sanju.mehta@amd.com>

I had to rework the first patch, since Jiasen's patch was already in
my tree for a couple months. The rest applied fine and will be in my
git trees on github in a couple of hours (sanity build pending).

Thanks,
Jon

>
>
> >
> > drivers/ntb/hw/amd/ntb_hw_amd.c | 290 ++++++++++++++++++++++++++------
> > drivers/ntb/hw/amd/ntb_hw_amd.h | 8 +-
> > 2 files changed, 247 insertions(+), 51 deletions(-)
> >
> > --
> > 2.17.1
> >

\
 
 \ /
  Last update: 2020-03-13 01:26    [W:0.135 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site