lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files
From
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Thu, 12 Mar 2020 23:10:32 +0100

> +inline int vsc8584_macsec_init(struct phy_device *phydev)
> +{
> + return 0;
> +}
> +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev)
> +{
> +}
> +inline void vsc8584_config_macsec_intr(struct phy_device *phydev)
> +{
> +}

Please use "static inline", as otherwise if this file is included multiple times it
will cause the compiler to emit potentially two uninlined copies which will result
in a linking error.

\
 
 \ /
  Last update: 2020-03-12 23:44    [W:0.039 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site