lkml.org 
[lkml]   [2020]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings
On Fri, Mar 06, 2020 at 04:03:40PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> Optional regmap property will be used to refer to a syscon-controller
> having a reboot tolerant register mapped.

NAK. It should simply be a child node of the 'syscon-controller'.

>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> .../bindings/power/reset/syscon-reboot-mode.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> index e09bb07b1abb..f47bf52ad983 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> @@ -13,9 +13,8 @@ description: |
> This driver gets reboot mode magic value from reboot-mode driver
> and stores it in a SYSCON mapped register. Then the bootloader
> can read it and take different action according to the magic
> - value stored. The SYSCON mapped register is retrieved from the
> - parental dt-node plus the offset. So the SYSCON reboot-mode node
> - should be represented as a sub-node of a "syscon", "simple-mfd" node.
> + value stored. The SYSCON mapped register is retrieved either from
> + the parental dt-node or from a regmap phandle plus the offset.
>
> properties:
> compatible:
> @@ -29,6 +28,10 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: Offset in the register map for the mode register (in bytes).
>
> + regmap:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the register map node.
> +
> patternProperties:
> "^mode-.+":
> $ref: /schemas/types.yaml#/definitions/uint32
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2020-03-12 22:15    [W:0.135 / U:2.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site