Messages in this thread | | | Subject | Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation | From | masonccyang@mxic ... | Date | Wed, 11 Mar 2020 14:13:57 +0800 |
| |
Hi Boris,
> > > --- > > > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++--- > > > include/linux/mtd/rawnand.h | 4 ++++ > > > 2 files changed, 12 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > > index 769be81..b44e460 100644 > > > --- a/drivers/mtd/nand/raw/nand_base.c > > > +++ b/drivers/mtd/nand/raw/nand_base.c > > > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info *mtd) > > > struct nand_chip *chip = mtd_to_nand(mtd); > > > > > > mutex_lock(&chip->lock); > > > - chip->suspended = 1; > > > + if (chip->_suspend) > > > + if (!chip->_suspend(chip)) > > > + chip->suspended = 1; > > Shouldn't you propagate the error to the caller if chip->_suspend() > fails?
Currently, chip->suspend() just do sending command to nand chip and I think caller could check chip->suspend = 1 or 0 to know the status of nand chip.
thanks & best regards, Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
| |