lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

Ulf Hansson <ulf.hansson@linaro.org> wrote on Wed, 11 Mar 2020 15:20:59
+0100:

> On Wed, 11 Mar 2020 at 08:40, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Joe,
> >
> > Joe Perches <joe@perches.com> wrote on Tue, 10 Mar 2020 21:51:27 -0700:
> >
> > > Convert the various uses of fallthrough comments to fallthrough;
> > >
> > > Done via script
> > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > > ---
> > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
> > > drivers/mmc/host/jz4740_mmc.c | 6 ++----
> > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
> > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++--
> > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++--
> > > sound/soc/codecs/jz4770.c | 2 +-
> > > 6 files changed, 9 insertions(+), 11 deletions(-)
> >
> > I like very much the new way to advertise for fallthrough statements,
> > but I am not willing to take any patch converting a single driver
> > anymore. I had too many from Gustavo when these comments had to be
> > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a
> > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/).
> >
> > Hope you'll understand!
>
> I fully agree (for mmc). One patch please.
>
> Another option is to make a big fat tree wide patch and ask Linus if
> he want to pick up immediately after an rc1. That should cause less
> disturbance for everyone, no?

Absolutely.

Miquèl

\
 
 \ /
  Last update: 2020-03-11 15:30    [W:0.268 / U:13.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site