Messages in this thread | | | Date | Wed, 11 Mar 2020 12:20:52 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support |
| |
On 03/10/20 at 03:46pm, Michal Hocko wrote: > On Sat 07-03-20 16:42:27, Baoquan He wrote: > > And tell check_pfn_span() gating the porper alignment and size of > > hot added memory region. > > > > And also move the code comments from inside section_deactivate() > > to being above it. The code comments are reasonable for the whole > > function, and the moving makes code cleaner. > > > > Signed-off-by: Baoquan He <bhe@redhat.com> > > Acked-by: Michal Hocko <mhocko@suse.com> > > I have glanced through other patches and they seem sane but I do not > have time to go deeper to give an ack. I like this one though because it > really makes the intention clearer.
Thanks for your reviewing and providing ack on this patch.
I will post a new version to rebase on the top of patch 1 and its appended fix, then address those concerns from David.
| |