lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;
On Wed, Mar 11, 2020 at 2:07 PM Joe Perches <joe@perches.com> wrote:
>
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>


Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>


But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"



> ---
> drivers/tty/serial/8250/8250_uniphier.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index e0b73a5..a2978ab 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
> break;
> case UART_LCR:
> valshift = 8;
> - /* fall through */
> + fallthrough;
> case UART_MCR:
> offset = UNIPHIER_UART_LCR_MCR;
> break;
> @@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
> case UART_SCR:
> /* No SCR for this hardware. Use CHAR as a scratch register */
> valshift = 8;
> - /* fall through */
> + fallthrough;
> case UART_FCR:
> offset = UNIPHIER_UART_CHAR_FCR;
> break;
> @@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
> valshift = 8;
> /* Divisor latch access bit does not exist. */
> value &= ~UART_LCR_DLAB;
> - /* fall through */
> + fallthrough;
> case UART_MCR:
> offset = UNIPHIER_UART_LCR_MCR;
> break;
> --
> 2.24.0
>


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-03-11 06:16    [W:0.217 / U:1.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site