Messages in this thread | | | Date | Wed, 11 Mar 2020 11:42:17 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() |
| |
On Wed, Mar 11, 2020 at 02:33:08PM +0530, afzal mohammed wrote: > diff --git a/arch/mips/kernel/cevt-r4k.c b/arch/mips/kernel/cevt-r4k.c > index 64e917dfe6b2..d24e4f2985c3 100644 > --- a/arch/mips/kernel/cevt-r4k.c > +++ b/arch/mips/kernel/cevt-r4k.c > @@ -252,7 +252,7 @@ unsigned int __weak get_c0_compare_int(void) > > int r4k_clockevent_init(void) > { > - unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED; > + unsigned long flags = IRQF_PERCPU | IRQF_TIMER; > unsigned int cpu = smp_processor_id(); > struct clock_event_device *cd; > unsigned int irq, min_delta;
I don't see why this should help. In my tree only sgi-ip30 removes IRQF_SHARED from flags, but then it uses setup_percpu_irq(). What do I miss ?
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |