lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] crypto: engine - support for parallel requests
On Mon, Mar 09, 2020 at 12:51:32AM +0200, Iuliana Prodan wrote:
>
> ret = enginectx->op.do_one_request(engine, async_req);
> - if (ret) {
> - dev_err(engine->dev, "Failed to do one request from queue: %d\n", ret);
> - goto req_err;
> + can_enq_more = ret;
> + if (can_enq_more < 0) {
> + dev_err(engine->dev, "Failed to do one request from queue: %d\n",
> + ret);
> + goto req_err_1;
> + }

So this now includes the case of the hardware queue being full
and the request needs to be queued until space opens up again.
In this case, we should not do dev_err. So you need to be able
to distinguish between the hardware queue being full vs. a real
fatal error on the request (e.g., out-of-memory or some hardware
failure).

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2020-03-12 04:27    [W:0.118 / U:3.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site