lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/3] dt-bindings: power: supply: add cw2015_battery bindings
From
Date
Hi Daniel,

thanks for reviewing. The typo will be fixed for v4.

>> + power-supplies:
>> + description:
>> + Specifies supplies used for charging the battery connected to this gauge
>> + allOf:
>> + - $ref: /schemas/types.yaml#/definitions/phandle-array
>> + - minItems: 1
>> + maxItems: 8 # Should be enough
>
> Is it necessary to set a maximum? power_supply.txt is still a text file
> but there is no mention of a maximum there.
>
I think so? Removing maxItems and running dtbs_check on a dts with more
than one supply phandle in the power-supplies property results in an error:
linux/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dt.yaml:
cw2015@62: power-supplies: [[142], [50]] is too long

Best Regards,

Tobias

\
 
 \ /
  Last update: 2020-03-12 00:17    [W:0.113 / U:29.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site