lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] virtio: virtio_pci_legacy: Remove default y from Kconfig
On Wed, Mar 11, 2020 at 03:44:14PM -0700, Ram Muthiah wrote:
> On Sat, Feb 29, 2020 at 11:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Fri, Feb 28, 2020 at 03:27:36PM -0800, Ram Muthiah wrote:
> > > The legacy pci driver should no longer be default enabled. QEMU has
> > > implemented support for Virtio 1 for virtio-pci since June 2015
> > > on SHA dfb8e184db75.
> > >
> > > Signed-off-by: Ram Muthiah <rammuthiah@google.com>
> >
> > I see little reason to do this: y is safer and will boot on more
> > hypervisors, so people that aren't sure should enable it.
> >
>
> In that case, would it be reasonable to fold VIRTIO_PCI_LEGACY
> into VIRTIO_PCI?
>
> The result would boot more hypervisors as well and remove the
> CONFIG in the process.

This might break configurations relying on the flying car joke to be
there.


> > > ---
> > > drivers/virtio/Kconfig | 6 ------
> > > 1 file changed, 6 deletions(-)
> > >
> > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > > index 078615cf2afc..eacd0b90d32b 100644
> > > --- a/drivers/virtio/Kconfig
> > > +++ b/drivers/virtio/Kconfig
> > > @@ -26,7 +26,6 @@ config VIRTIO_PCI
> > >
> > > config VIRTIO_PCI_LEGACY
> > > bool "Support for legacy virtio draft 0.9.X and older devices"
> > > - default y
> > > depends on VIRTIO_PCI
> > > ---help---
> > > Virtio PCI Card 0.9.X Draft (circa 2014) and older device support.
> > > @@ -36,11 +35,6 @@ config VIRTIO_PCI_LEGACY
> > > If disabled, you get a slightly smaller, non-transitional driver,
> > > with no legacy compatibility.
> > >
> > > - So look out into your driveway. Do you have a flying car? If
> > > - so, you can happily disable this option and virtio will not
> > > - break. Otherwise, leave it set. Unless you're testing what
> > > - life will be like in The Future.
> > > -
> > > If unsure, say Y.
> > >
> > > config VIRTIO_PMEM
> > > --
> > > 2.25.0.265.gbab2e86ba0-goog
> >

\
 
 \ /
  Last update: 2020-03-12 00:03    [W:0.047 / U:29.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site