lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 46/86] tty:serial:mvebu-uart:fix a wrong return
    Date
    From: tangbin <tangbin@cmss.chinamobile.com>

    commit 4a3e208474204e879d22a310b244cb2f39e5b1f8 upstream.

    in this place, the function should return a
    negative value and the PTR_ERR already returns
    a negative,so return -PTR_ERR() is wrong.

    Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
    Cc: stable <stable@vger.kernel.org>
    Acked-by: Jiri Slaby <jslaby@suse.cz>
    Link: https://lore.kernel.org/r/20200305013823.20976-1-tangbin@cmss.chinamobile.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/tty/serial/mvebu-uart.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/tty/serial/mvebu-uart.c
    +++ b/drivers/tty/serial/mvebu-uart.c
    @@ -840,7 +840,7 @@ static int mvebu_uart_probe(struct platf

    port->membase = devm_ioremap_resource(&pdev->dev, reg);
    if (IS_ERR(port->membase))
    - return -PTR_ERR(port->membase);
    + return PTR_ERR(port->membase);

    mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
    GFP_KERNEL);

    \
     
     \ /
      Last update: 2020-03-10 14:13    [W:4.172 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site