lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 177/189] hwmon: (adt7462) Fix an error return in ADT7462_REG_VOLT()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 44f2f882909fedfc3a56e4b90026910456019743 upstream.

    This is only called from adt7462_update_device(). The caller expects it
    to return zero on error. I fixed a similar issue earlier in commit
    a4bf06d58f21 ("hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0")
    but I missed this one.

    Fixes: c0b4e3ab0c76 ("adt7462: new hwmon driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Link: https://lore.kernel.org/r/20200303101608.kqjwfcazu2ylhi2a@kili.mountain
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwmon/adt7462.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwmon/adt7462.c
    +++ b/drivers/hwmon/adt7462.c
    @@ -413,7 +413,7 @@ static int ADT7462_REG_VOLT(struct adt74
    return 0x95;
    break;
    }
    - return -ENODEV;
    + return 0;
    }

    /* Provide labels for sysfs */

    \
     
     \ /
      Last update: 2020-03-10 14:04    [W:5.503 / U:0.836 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site