lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 回复:[PATCH 1/6] PCI: Add Loongson vend or ID and 7A1000 device IDs
From
Date
On 03/10/2020 10:37 AM, Jiaxun Yang wrote:
>
> 于 2020年3月10日 GMT+08:00 上午10:31:56, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>> On 03/09/2020 04:50 PM, Jiaxun Yang wrote:
>>> ---- 在 星期一, 2020-03-09 16:23:21 Tiezhu Yang
>> <yangtiezhu@loongson.cn> 撰写 ----
>>> > Add the Loongson vendor ID and 7A1000 device IDs to pci_ids.h
>>> > to be used by the controller driver in the future.
>>> >
>>> > The Loongson IDs can be found at the following link:
>>> >
>> https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
>>> >
>>> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>> > ---
>>> > include/linux/pci_ids.h | 18 ++++++++++++++++++
>>> > 1 file changed, 18 insertions(+)
>>> >
>>> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>>> > index 352c0d7..0125ab4 100644
>>> > --- a/include/linux/pci_ids.h
>>> > +++ b/include/linux/pci_ids.h
>>> > @@ -3113,4 +3113,22 @@
>>> >
>>> > #define PCI_VENDOR_ID_NCUBE 0x10ff
>>> >
>>> > +#define PCI_VENDOR_ID_LOONGSON 0x0014
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HT 0x7a00
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_APB 0x7a02
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GMAC 0x7a03
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OTG 0x7a04
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DC 0x7a06
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HDA 0x7a07
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SATA 0x7a08
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X1 0x7a09
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SPI 0x7a0b
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_LPC 0x7a0c
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DMA 0x7a0f
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_EHCI 0x7a14
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GPU 0x7a15
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X4 0x7a19
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OHCI 0x7a24
>>> > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X8 0x7a29
>>>
>>> Devices IDs are unlikely to be reused by mutiple subsystems, so
>> probably we don't need
>>> to add them here?
>> Hi Jiaxun,
>>
>> I think it is better to define the device IDs in pci_ids.h,
>> otherwise it seems a little disorganized.
> Please read the comment at the start of this file.
> New entries should be added only if they're shared by multiple drivers.
>
> That's the rule.
>
> And probably you can split these two patches into a new series
> as they're likely to be accepted.

OK, that makes sense.

Let me split the two patches 1/6 and 2/6 into a new series,
the first patch only adds the Loongson vendor ID to pci_ids.h.

Thanks,

Tiezhu Yang

>
> Thanks.
>
>> Thanks,
>>
>> Tiezhu Yang
>>
>>>
>>>> +
>>> > #endif /* _LINUX_PCI_IDS_H */
>>> > --
>>> > 2.1.0
>>> >
>>> >

\
 
 \ /
  Last update: 2020-03-10 10:29    [W:0.035 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site