Messages in this thread | | | Subject | Re: [PATCH v2] block: refactor duplicated macros | From | Guoqing Jiang <> | Date | Wed, 11 Mar 2020 00:10:04 +0100 |
| |
On 3/10/20 11:35 PM, Matteo Croce wrote: > +++ b/drivers/md/raid1.c > @@ -2129,7 +2129,7 @@ static void process_checks(struct r1bio *r1_bio) > int vcnt; > > /* Fix variable parts of all bios */ > - vcnt = (r1_bio->sectors + PAGE_SIZE / 512 - 1) >> (PAGE_SHIFT - 9); > + vcnt = (r1_bio->sectors + PAGE_SECTORS - 1) >> (PAGE_SHIFT - 9);
Maybe replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too.
Thanks, Guoqing
| |