lkml.org 
[lkml]   [2020]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 3/5] remoteproc: qcom: Update PIL relocation info on load
    From
    Date
    Quoting Bjorn Andersson (2020-03-09 23:33:36)
    > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
    > index e953886b2eb7..d5cdff942535 100644
    > --- a/drivers/remoteproc/qcom_q6v5_adsp.c
    > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
    > @@ -164,10 +166,18 @@ static int qcom_adsp_shutdown(struct qcom_adsp *adsp)
    > static int adsp_load(struct rproc *rproc, const struct firmware *fw)
    > {
    > struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv;
    > + int ret;
    > +
    > + ret = qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, 0,
    > + adsp->mem_region, adsp->mem_phys,
    > + adsp->mem_size, &adsp->mem_reloc);
    > + if (ret)
    > + return ret;
    >
    > - return qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, 0,
    > - adsp->mem_region, adsp->mem_phys, adsp->mem_size,
    > - &adsp->mem_reloc);
    > + /* Failures only affect post mortem debugging, so ignore return value */
    > + qcom_pil_info_store(adsp->info_name, adsp->mem_reloc, adsp->mem_size);

    If the return value was void then the comment wouldn't be necessary and
    it would be self documenting as such. Can we do that?

    \
     
     \ /
      Last update: 2020-03-10 19:11    [W:6.519 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site