lkml.org 
[lkml]   [2020]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/11] hrtimer: Add missing annotation to lock_hrtimer_base()
    Date
    Sparse reports several warnings;
    warning: context imbalance in lock_hrtimer_base() - wrong count at exit
    warning: context imbalance in hrtimer_start_range_ns() - unexpected unlock
    warning: context imbalance in hrtimer_try_to_cancel() - unexpected unlock
    warning: context imbalance in __hrtimer_get_remaining() - unexpected unlock

    The root cause is a missing annotation of lock_hrtimer_base() which
    causes also the "unexpected unlock" warnings.

    Add the missing __acquires(timer->base) annotation

    Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
    ---
    kernel/time/hrtimer.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
    index 3a609e7344f3..bb8340e2a3b9 100644
    --- a/kernel/time/hrtimer.c
    +++ b/kernel/time/hrtimer.c
    @@ -160,6 +160,7 @@ static inline bool is_migration_base(struct hrtimer_clock_base *base)
    static
    struct hrtimer_clock_base *lock_hrtimer_base(const struct hrtimer *timer,
    unsigned long *flags)
    + __acquires(timer->base)
    {
    struct hrtimer_clock_base *base;

    --
    2.24.1
    \
     
     \ /
      Last update: 2020-02-09 23:27    [W:3.008 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site