lkml.org 
[lkml]   [2020]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs
    On 2020-02-04 23:51, Evan Green wrote:
    > On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@codeaurora.org>
    > wrote:
    >>
    >> In order to better represent the hardware and its different
    >> Network-On-Chip
    >> devices, split the sdm845 provider driver into NoC specific providers.
    >> Remove duplicate functionality already provided by the icc rpmh and
    >> bcm voter drivers to calculate and commit bandwidth requests to
    >> hardware.
    >>
    >> Signed-off-by: David Dai <daidavid1@codeaurora.org>
    >> ---
    >> drivers/interconnect/qcom/sdm845.c | 1132
    >> ++++++++++--------------
    >> include/dt-bindings/interconnect/qcom,sdm845.h | 263 +++---
    >> 2 files changed, 609 insertions(+), 786 deletions(-)
    >>
    >> diff --git a/drivers/interconnect/qcom/sdm845.c
    >> b/drivers/interconnect/qcom/sdm845.c
    >> index f078cf0..8145612 100644
    >> --- a/drivers/interconnect/qcom/sdm845.c
    >> +++ b/drivers/interconnect/qcom/sdm845.c
    >> @@ -5,283 +5,285 @@
    >> */
    >>
    >> #include <asm/div64.h>
    >
    > You don't need this header anymore, right?
    >
    >> -#include <dt-bindings/interconnect/qcom,sdm845.h>
    >> #include <linux/device.h>
    >> #include <linux/interconnect.h>
    >> #include <linux/interconnect-provider.h>
    >> #include <linux/io.h>

    ^^ can also be dropped

    >> #include <linux/module.h>
    >> #include <linux/of_device.h>
    >> -#include <linux/of_platform.h>

    ^^ can also be dropped

    >> -#include <linux/platform_device.h>
    >> #include <linux/sort.h>
    >
    > ..or this one.

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project.

    \
     
     \ /
      Last update: 2020-02-09 19:05    [W:2.316 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site